-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added new workflow to test updated nightly #119
Conversation
path: app-boilerplate/build/* | ||
if-no-files-found: error | ||
|
||
ragger_tests: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need to run this in the dev-tools image (not the regular app-builder, it doesn't have Ragger nor Speculos)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall be fixed in reusable_ragger_tests flow as it uses ubuntu-latest
nowadays.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird to use ubuntu-latest
and then do
- name: Install tests dependencies
run: |
sudo apt-get update && sudo apt-get install -y qemu-user-static tesseract-ocr libtesseract-dev
pip install -U pip setuptools
pip install -r "${{ needs.call_get_app_metadata.outputs.pytest_directory }}/requirements.txt"
in the reusable workflow... Maybe it's because we want to be closer to a real host environment ? 🤔
We wouldn't need the Install tests dependencies
if we used the app-dev-tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see LedgerHQ/ledger-app-workflows#56, I do not know why an ubuntu env is used to run test (rather than our dev-tools container)...
No description provided.